fix: Prevent crash when global URL constructor is not defined #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
reviewed
Sep 2, 2025
Collaborator
Skn0tt
left a comment
Skn0tt
left a comment
There was a problem hiding this comment.
Thanks for the PR, I like it. Could you add a reproduction test? If you delete globalThis.URL at the beginning of the test, and reinstante at the end, you can simulate an environment that doesn't have URL.
Author
|
Hi, I've just added a test following your suggestion to simulate an environment without URL. It no longer throws errors now. Looking forward to your review! |
Collaborator
|
uh-oh, could you take a look at the linter? |
Author
|
Okay, I've fixed the lint issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
Currently,
superjson's internalisURLcheck (payload instanceof URL) will throw aTypeError: Right-hand side of 'instanceof' is not an objectin JavaScript environments where the globalURLconstructor is not available.This issue occurs in environments like:
This prevents users in these growing ecosystems from using
superjsonwithout applying workarounds like global polyfills or custom configuration overrides.The Solution
This PR adds a guard clause (
typeof URL !== 'undefined') before theinstanceofcheck. By leveraging short-circuiting, this ensures thatinstanceof URLis only evaluated when theURLconstructor actually exists.URL: The check now correctly and safely returnsfalseinstead of crashing.This is a minimal, non-breaking change that significantly improves the library's robustness and compatibility.